]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
serial: amba-pl011: prefer dma_mapping_error() over explicit address checking
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 27 Oct 2025 09:20:50 +0000 (17:20 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Dec 2025 21:12:43 +0000 (06:12 +0900)
commitd109718f21fa56a05caa0392e841b2f896baefcb
tree81d0f0052fd696dafec7ab43e8d900a5fce0e061
parentb359df793f609b1efce31dadfe6883ec73852619
serial: amba-pl011: prefer dma_mapping_error() over explicit address checking

commit eb4917f557d43c7a1c805dd73ffcdfddb2aba39a upstream.

Check for returned DMA addresses using specialized dma_mapping_error()
helper which is generally recommended for this purpose by
Documentation/core-api/dma-api.rst:

  "In some circumstances dma_map_single(), ...
will fail to create a mapping. A driver can check for these errors
by testing the returned DMA address with dma_mapping_error()."

Found via static analysis and this is similar to commit fa0308134d26
("ALSA: memalloc: prefer dma_mapping_error() over explicit address checking")

Fixes: 58ac1b379979 ("ARM: PL011: Fix DMA support")
Cc: stable <stable@kernel.org>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Link: https://patch.msgid.link/20251027092053.87937-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/amba-pl011.c