]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netfilter: nf_tables: skip set commit for deleted/destroyed sets
authorPablo Neira Ayuso <pablo@netfilter.org>
Tue, 19 Dec 2023 18:44:49 +0000 (19:44 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Jan 2024 14:13:39 +0000 (15:13 +0100)
commitd10f7540c5541ad9f4fe2a02a73153d25d4a540d
treee841491a4c69c16b0476bbb2ec9595cba0bb49f8
parentd739f2b6d8f57aa9377362cd8c0b1152a4dd6bd5
netfilter: nf_tables: skip set commit for deleted/destroyed sets

commit 7315dc1e122c85ffdfc8defffbb8f8b616c2eb1a upstream.

NFT_MSG_DELSET deactivates all elements in the set, skip
set->ops->commit() to avoid the unnecessary clone (for the pipapo case)
as well as the sync GC cycle, which could deactivate again expired
elements in such set.

Fixes: 5f68718b34a5 ("netfilter: nf_tables: GC transaction API to avoid race with control plane")
Reported-by: Kevin Rich <kevinrich1337@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nf_tables_api.c