]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
counter: interrupt-cnt: Protect enable/disable OPs with mutex
authorAlexander Sverdlin <alexander.sverdlin@siemens.com>
Mon, 31 Mar 2025 16:36:40 +0000 (18:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:07:16 +0000 (11:07 +0100)
commitd12828d95ff4b0ee240e976094510478669314db
treec3d31cdb10fd3613129c2690c273b246c4376da6
parentcda0211f95309da58898b64262aa98d467306259
counter: interrupt-cnt: Protect enable/disable OPs with mutex

[ Upstream commit 7351312632e831e51383f48957d47712fae791ef ]

Enable/disable seems to be racy on SMP, consider the following scenario:

CPU0 CPU1

interrupt_cnt_enable_write(true)
{
if (priv->enabled == enable)
return 0;

if (enable) {
priv->enabled = true;
interrupt_cnt_enable_write(false)
{
if (priv->enabled == enable)
return 0;

if (enable) {
priv->enabled = true;
enable_irq(priv->irq);
} else {
disable_irq(priv->irq)
priv->enabled = false;
}
enable_irq(priv->irq);
} else {
disable_irq(priv->irq);
priv->enabled = false;
}

The above would result in priv->enabled == false, but IRQ left enabled.
Protect both write (above race) and read (to propagate the value on SMP)
callbacks with a mutex.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Fixes: a55ebd47f21f ("counter: add IRQ or GPIO based counter")
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/r/20250331163642.2382651-1-alexander.sverdlin@siemens.com
Signed-off-by: William Breathitt Gray <wbg@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/counter/interrupt-cnt.c