]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: sgtl5000: Fix SMALL_POP bit definition
authorFabio Estevam <fabio.estevam@freescale.com>
Fri, 14 Nov 2014 04:14:47 +0000 (02:14 -0200)
committerJiri Slaby <jslaby@suse.cz>
Sat, 6 Dec 2014 14:14:52 +0000 (15:14 +0100)
commitd1c6c007710cb9b487e79e1e4e34d4efd8e4f2d2
tree2770cd1cff7e59f0755346d9f0b5dcf727bc41c4
parentbefc717fc64a47bbb7cb3998f3bf8eb09c91faf1
ASoC: sgtl5000: Fix SMALL_POP bit definition

commit c251ea7bd7a04f1f2575467e0de76e803cf59149 upstream.

On a mx28evk with a sgtl5000 codec we notice a loud 'click' sound  to happen
5 seconds after the end of a playback.

The SMALL_POP bit should fix this, but its definition is incorrect:
according to the sgtl5000 manual it is bit 0 of CHIP_REF_CTRL register, not
bit 1.

Fix the definition accordingly and enable the bit as intended per the code
comment.

After applying this change, no loud 'click' sound is heard after playback

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
sound/soc/codecs/sgtl5000.c
sound/soc/codecs/sgtl5000.h