]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nfsd: destroy percpu stats counters after reply cache shutdown
authorJulian Schroeder <jumaco@amazon.com>
Mon, 23 May 2022 18:52:26 +0000 (18:52 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:26:10 +0000 (10:26 +0200)
commitd1c8dcdb684db0f596ad6daa4769ae6654929a9b
treeaaac12dcea479a1e551d4f02291182772a60a362
parent2d00158a06efe6bbcd020108634ea0f2ed8b32f7
nfsd: destroy percpu stats counters after reply cache shutdown

[ Upstream commit fd5e363eac77ef81542db77ddad0559fa0f9204e ]

Upon nfsd shutdown any pending DRC cache is freed. DRC cache use is
tracked via a percpu counter. In the current code the percpu counter
is destroyed before. If any pending cache is still present,
percpu_counter_add is called with a percpu counter==NULL. This causes
a kernel crash.
The solution is to destroy the percpu counter after the cache is freed.

Fixes: e567b98ce9a4b (“nfsd: protect concurrent access to nfsd stats counters”)
Signed-off-by: Julian Schroeder <jumaco@amazon.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfsd/nfscache.c