]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mac80211: ignore NullFunc frames in the duplicate detection
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Mon, 3 Dec 2018 19:16:07 +0000 (21:16 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Dec 2018 08:21:37 +0000 (09:21 +0100)
commitd1deb58639b05e14b5dd859f587edc628aa4f4e0
treef00b9959c09141b2a154abd926fb6bbba5c5ae55
parent5a7b2af0c7ec872ffd4b0b87e4f102108e112af0
mac80211: ignore NullFunc frames in the duplicate detection

commit 990d71846a0b7281bd933c34d734e6afc7408e7e upstream.

NullFunc packets should never be duplicate just like
QoS-NullFunc packets.

We saw a client that enters / exits power save with
NullFunc frames (and not with QoS-NullFunc) despite the
fact that the association supports HT.
This specific client also re-uses a non-zero sequence number
for different NullFunc frames.
At some point, the client had to send a retransmission of
the NullFunc frame and we dropped it, leading to a
misalignment in the power save state.
Fix this by never consider a NullFunc frame as duplicate,
just like we do for QoS NullFunc frames.

This fixes https://bugzilla.kernel.org/show_bug.cgi?id=201449

CC: <stable@vger.kernel.org>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/mac80211/rx.c