]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Disallow replacing joins with scans in problematic cases.
authorEtsuro Fujita <efujita@postgresql.org>
Fri, 28 Jul 2023 06:45:02 +0000 (15:45 +0900)
committerEtsuro Fujita <efujita@postgresql.org>
Fri, 28 Jul 2023 06:45:02 +0000 (15:45 +0900)
commitd1ef5631e620f9a5b6480a32bb70124c857af4f1
tree2a419ed90878ca112c8c0a72078001e1aa7f5dee
parent313ceda2fe2ee8dd903ad4773f54de14807807c6
Disallow replacing joins with scans in problematic cases.

Commit e7cb7ee14, which introduced the infrastructure for FDWs and
custom scan providers to replace joins with scans, failed to add support
handling of pseudoconstant quals assigned to replaced joins in
createplan.c, leading to an incorrect plan without a gating Result node
when postgres_fdw replaced a join with such a qual.

To fix, we could add the support by 1) modifying the ForeignPath and
CustomPath structs to store the list of RestrictInfo nodes to apply to
the join, as in JoinPaths, if they represent foreign and custom scans
replacing a join with a scan, and by 2) modifying create_scan_plan() in
createplan.c to use that list in that case, instead of the
baserestrictinfo list, to get pseudoconstant quals assigned to the join;
but #1 would cause an ABI break.  So fix by modifying the infrastructure
to just disallow replacing joins with such quals.

Back-patch to all supported branches.

Reported by Nishant Sharma.  Patch by me, reviewed by Nishant Sharma and
Richard Guo.

Discussion: https://postgr.es/m/CADrsxdbcN1vejBaf8a%2BQhrZY5PXL-04mCd4GDu6qm6FigDZd6Q%40mail.gmail.com
contrib/postgres_fdw/expected/postgres_fdw.out
contrib/postgres_fdw/sql/postgres_fdw.sql
src/backend/optimizer/path/joinpath.c
src/backend/optimizer/util/restrictinfo.c
src/include/optimizer/restrictinfo.h