]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
exportfs: do not read dentry after free
authorPan Bian <bianpan2016@163.com>
Fri, 23 Nov 2018 07:56:33 +0000 (15:56 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 08:38:33 +0000 (09:38 +0100)
commitd2139ee71c89345e946f4df175d87bfce3dbe363
treee9dd2cc384ab013d8e16e34e5e516c3cd11e2e9f
parent476a607331b7cc51a5283e344b11b19ac04ef72f
exportfs: do not read dentry after free

[ Upstream commit 2084ac6c505a58f7efdec13eba633c6aaa085ca5 ]

The function dentry_connected calls dput(dentry) to drop the previously
acquired reference to dentry. In this case, dentry can be released.
After that, IS_ROOT(dentry) checks the condition
(dentry == dentry->d_parent), which may result in a use-after-free bug.
This patch directly compares dentry with its parent obtained before
dropping the reference.

Fixes: a056cc8934c("exportfs: stop retrying once we race with
rename/remove")

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/exportfs/expfs.c