]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
dlm: fix add msg handle in send_queue ordered
authorAlexander Aring <aahringo@redhat.com>
Mon, 27 Apr 2026 15:59:34 +0000 (11:59 -0400)
committerDavid Teigland <teigland@redhat.com>
Fri, 8 May 2026 13:38:03 +0000 (08:38 -0500)
commitd2248cb70c070f8f04762872772e155b59016f17
treef1054e1f1bdd46f281cbaae330fe1a7cec199792
parentb5314f2c6654a3616fd72777deb1ca766cc50618
dlm: fix add msg handle in send_queue ordered

In a benchmark scenario triggering a lot of requests that triggers a lot
of DLM messages on the network it can be that the mh->seq is not ordered
according the oldest seq number. This ordering is required by
dlm_receive_ack as "before(mh->seq, seq)" will stop to check for older
sequence numbers that are ordered in the tail of "node->send_queue".

The side effects of not having it correct ordered regarding
"before(mh->seq, seq)" are refcounting issues and use-after free.

I only was able to reproduce this issue in a experimental DLM branch
and a user space DLM benchmark that uses io_uring. After changing this I
don't experienced any refcounting with the sending buffer issues anymore.

Fixes: 489d8e559c659 ("fs: dlm: add reliable connection if reconnect")
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/midcomms.c