]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI: Fix pci_create_slot() reference count leak
authorQiushi Wu <wu000273@umn.edu>
Thu, 28 May 2020 02:13:22 +0000 (21:13 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Sep 2020 09:19:24 +0000 (11:19 +0200)
commitd22aec437d771dc6b57b73ef14454a1aef44fa8c
tree7ab3e2f537ee934a0afcbdc9047c6571995849d3
parent535f69f4217178fd64c03b7b3c1421cfaf3d6e10
PCI: Fix pci_create_slot() reference count leak

[ Upstream commit 8a94644b440eef5a7b9c104ac8aa7a7f413e35e5 ]

kobject_init_and_add() takes a reference even when it fails.  If it returns
an error, kobject_put() must be called to clean up the memory associated
with the object.

When kobject_init_and_add() fails, call kobject_put() instead of kfree().

b8eb718348b8 ("net-sysfs: Fix reference count leak in
rx|netdev_queue_add_kobject") fixed a similar problem.

Link: https://lore.kernel.org/r/20200528021322.1984-1-wu000273@umn.edu
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/slot.c