]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: drop unused arguments for dump-guest-memory
authorEric Blake <eblake@redhat.com>
Mon, 17 Sep 2012 19:05:29 +0000 (13:05 -0600)
committerEric Blake <eblake@redhat.com>
Tue, 18 Sep 2012 02:44:29 +0000 (20:44 -0600)
commitd239085e956ca6ca42480e877e98a4302e91b853
treefc60b672153a2f2a7d9d9bd72b0c25986ea58f51
parent22acfdc7fc46e911a3fa0213b455a32ae7a653a3
qemu: drop unused arguments for dump-guest-memory

Upstream qemu has raised a concern about whether dumping guest
memory by reading guest paging tables is a security hole:
https://lists.gnu.org/archive/html/qemu-devel/2012-09/msg02607.html

While auditing libvirt to see if we would be impacted, I noticed
that we had some dead code.  It is simpler to nuke the dead code
and limit our monitor code to just the subset we make use of.

* src/qemu/qemu_monitor.h (QEMU_MONITOR_DUMP): Drop poorly named
and mostly-unused enum.
* src/qemu/qemu_monitor.c (qemuMonitorDumpToFd): Drop arguments.
* src/qemu/qemu_monitor_json.h (qemuMonitorJSONDump): Likewise.
* src/qemu/qemu_monitor_json.c (qemuMonitorJSONDump): Likewise.
* src/qemu/qemu_driver.c (qemuDumpToFd): Update caller.
src/qemu/qemu_driver.c
src/qemu/qemu_monitor.c
src/qemu/qemu_monitor.h
src/qemu/qemu_monitor_json.c
src/qemu/qemu_monitor_json.h