]> git.ipfire.org Git - thirdparty/asterisk.git/commit
Make CDR and CEL unit tests less FRACKy.
authorMark Michelson <mmichelson@digium.com>
Tue, 23 Sep 2014 14:29:01 +0000 (14:29 +0000)
committerMark Michelson <mmichelson@digium.com>
Tue, 23 Sep 2014 14:29:01 +0000 (14:29 +0000)
commitd25390073bd3c784d0e05e03d82200a88927cabc
tree32eabf2b563d5a2ac5aa633f2c46aedca793e818
parent0f3540553dc320f4322acff9b8c6be40ac8f7dda
Make CDR and CEL unit tests less FRACKy.

Prior to this commit, CDR and CEL tests were expected to trigger
FRACKs (i.e. assertions) due to the fact that the channels they
create have no formats on them. Some code was independently added
recently that attempts to prevent FRACKs from occurring by failing
early when attempting to set up translation paths if one or both
channels support no formats. Unfortunately, this attempt to be helpful
made the CDR and CEL tests go from simply FRACKing to outright
failing and in some cases, failing so badly as to crash Asterisk.

This commit seeks to correct past mistakes by adding the ulaw format
to channels created by the CDR and CEL unit tests. This makes setting
up translation paths succeed, eliminates previously-seen FRACKs, and
ultimately causes the unit tests to succeed again.

Review: https://reviewboard.asterisk.org/r/4014

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@423783 65c4cc65-6c06-0410-ace0-fbb531ad65f3
tests/test_cdr.c
tests/test_cel.c