]> git.ipfire.org Git - thirdparty/git.git/commit
pickaxe: die when --find-object and --pickaxe-all are combined
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Mon, 12 Apr 2021 17:15:15 +0000 (19:15 +0200)
committerJunio C Hamano <gitster@pobox.com>
Tue, 11 May 2021 03:47:31 +0000 (12:47 +0900)
commitd26ec8800969ea1b692e0c87100dc4235cfa12e2
tree52500f01b7ae76b9706ec15fc5ae71134d73e0a4
parent188e9e28c5287f3f160b5f14e3e551b1c55c7301
pickaxe: die when --find-object and --pickaxe-all are combined

Neither the --pickaxe-all documentation nor --find-object's has ever
suggested that you can combine the two. See f506b8e8b5 (git log/diff:
add -G<regexp> that greps in the patch text, 2010-08-23) and
15af58c1ad (diffcore: add a pickaxe option to find a specific blob,
2018-01-04).

But we've silently tolerated it, which makes the logic in
diffcore_pickaxe() harder to reason about. Let's assert that we won't
have the two combined.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff.c
diff.h
t/t4209-log-pickaxe.sh