]> git.ipfire.org Git - thirdparty/squid.git/commit
Restore Security::ErrorDetail::detailEntry initialization (#2364)
authorRicardo Ferreira Ribeiro <garb12@pm.me>
Fri, 30 Jan 2026 09:25:59 +0000 (09:25 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Mon, 9 Feb 2026 09:19:07 +0000 (09:19 +0000)
commitd2a59b8b36843953b0f535c983ffc2bbddc5ee82
tree65d2727289ea8cc4b2dfca729bd9f2d9cf0c1507
parentc5f977b39cdeeceba51bd4ab5b459e92f7f88974
Restore Security::ErrorDetail::detailEntry initialization (#2364)

2023 commit 4e143970 accidentally removed code that was setting
`detailEntry` data member, breaking `%ssl_error_descr` expansion:
`Security::ErrorDetail::printErrorDescription()` would always print
`[Not available]`.

Squid still printed non-configurable request-independent error code
_name_ correctly because the corresponding `printErrorCode()` method
only uses `detailEntry` as a performance optimization.

The effects of this fix are visible, for example, in generated
ERR_SECURE_CONNECT_FAIL error responses:

```diff
- <p>[Not available]: /CN=...</p>
+ <p>Certificate does not match domainname: /CN=...</p>
```

This is a Measurement Factory project.
src/security/ErrorDetail.cc