]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rtnetlink: NUL-terminate IFLA_PHYS_PORT_NAME string
authorMichal Schmidt <mschmidt@redhat.com>
Thu, 4 May 2017 14:48:58 +0000 (16:48 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 14 May 2017 12:08:29 +0000 (14:08 +0200)
commitd3081680506fe919f1ed51944cafa8c5cb9007ed
treedb24a575279c2c5e3327d4a8aad5f21fc54df0c6
parentdf6f3bcd6667a1a99a699ff12912d5f3952271e1
rtnetlink: NUL-terminate IFLA_PHYS_PORT_NAME string

[ Upstream commit 77ef033b687c3e030017c94a29bf6ea3aaaef678 ]

IFLA_PHYS_PORT_NAME is a string attribute, so terminate it with \0.
Otherwise libnl3 fails to validate netlink messages with this attribute.
"ip -detail a" assumes too that the attribute is NUL-terminated when
printing it. It often was, due to padding.

I noticed this as libvirtd failing to start on a system with sfc driver
after upgrading it to Linux 4.11, i.e. when sfc added support for
phys_port_name.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/core/rtnetlink.c