]> git.ipfire.org Git - thirdparty/patchwork.git/commit
views: Don't munge the 'From' field of patches
authorDoug Anderson <dianders@chromium.org>
Sat, 19 Nov 2016 19:32:09 +0000 (19:32 +0000)
committerStephen Finucane <stephen@that.guru>
Sun, 18 Dec 2016 22:39:42 +0000 (22:39 +0000)
commitd365402fb98dfb2c4aea4b58346096f85bdfa0c3
tree9a3cc0794485cab745ccc7bfd9952724b69e8309
parentb6d320686fbdbe3f57959d78cb0091fc853625e4
views: Don't munge the 'From' field of patches

At the moment patchwork always uses the official submitter name (as
patchwork understands it) as the "From" for patches that you receive.
This isn't quite what users expect and has some unfortunate
consequences.

The biggest problem is that patchwork saves the "official" name for an
email address the first time it sees an email from them.  If that name
is wrong (or was missing) patchwork will be confused even if future
emails from this person are fixed.  There are similar problems if a
user changes his/her name (get married?).

It seems better to just have each patch report the actual "From" that
was used to send that patch.  We'll still return the submitter in
'X-Patchwork-Submitter' just in case someone wants it.

Reported-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Stephen Finucane <stephen@that.guru>
patchwork/tests/test_mboxviews.py
patchwork/views/__init__.py