]> git.ipfire.org Git - thirdparty/git.git/commit
imap-send: drop unused fields from imap_cmd_cb
authorJeff King <peff@peff.net>
Mon, 3 Jul 2023 06:34:28 +0000 (02:34 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 5 Jul 2023 17:16:53 +0000 (10:16 -0700)
commitd378637d2fe9eed3bd3bd0858e6cc79a8f23510a
treefac4684be06dd5f7de8c2cb913d9e48aea03b120
parentec9e358a4a1a0f5513d57f5447d43e31a508dd17
imap-send: drop unused fields from imap_cmd_cb

The imap_cmd_cb struct has several fields which are totally unused.
Presumably they did useful things in the upstream isync code from which
this is derived, but they don't in our more limited program. This is
particularly confusing for the "done" callback, which (as of the
previous patch) no longer matches the signature of the adjacent "cont"
callback.

Since we're unlikely to share code with isync going forward, we should
feel free to simplify the code here. Note that "done" is examined but
never set, so we can also drop a little bit of code outside of the
struct definition.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
imap-send.c