]> git.ipfire.org Git - thirdparty/linux.git/commit
platform/x86: samsung-galaxybook: Fix problematic pointer cast
authorArmin Wolf <W_Armin@gmx.de>
Sun, 28 Dec 2025 21:41:31 +0000 (22:41 +0100)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 29 Dec 2025 10:55:50 +0000 (12:55 +0200)
commitd37cd54ebeac37a763fbf303ed25f8a6e98328ff
tree8770d48ede8fdf2194ba853efa3365b8a5859cf1
parent00c22b1e84288bf0e17ab1e7e59d75237cf0d0dc
platform/x86: samsung-galaxybook: Fix problematic pointer cast

A user reported that reading the charge threshold on his device
results in very strange values (like 78497792) being returned.
The reason for this seems to be the fact that the driver casts
the int pointer to an u8 pointer, leaving the last 3 bytes of
the destination uninitialized. Fix this by using a temporary
variable instead.

Cc: stable@vger.kernel.org
Fixes: 56f529ce4370 ("platform/x86: samsung-galaxybook: Add samsung-galaxybook driver")
Reported-by: Gianni Ceccarelli <dakkar@thenautilus.net>
Closes: https://lore.kernel.org/platform-driver-x86/20251228115556.14362d66@thenautilus.net/
Tested-by: Gianni Ceccarelli <dakkar@thenautilus.net>
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://patch.msgid.link/20251228214217.35972-1-W_Armin@gmx.de
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/samsung-galaxybook.c