]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/imagination: Fix kernel crash when hard resetting the GPU
authorAlessio Belle <alessio.belle@imgtec.com>
Tue, 24 Jun 2025 14:22:08 +0000 (15:22 +0100)
committerMatt Coster <matt.coster@imgtec.com>
Fri, 4 Jul 2025 15:32:10 +0000 (16:32 +0100)
commitd38376b3ee48d073c64e75e150510d7e6b4b04f7
treee5b631ea7ffd7b949298a8ac89353d125a2dc3bb
parent44306a684cd1699b8562a54945ddc43e2abc9eab
drm/imagination: Fix kernel crash when hard resetting the GPU

The GPU hard reset sequence calls pm_runtime_force_suspend() and
pm_runtime_force_resume(), which according to their documentation should
only be used during system-wide PM transitions to sleep states.

The main issue though is that depending on some internal runtime PM
state as seen by pm_runtime_force_suspend() (whether the usage count is
<= 1), pm_runtime_force_resume() might not resume the device unless
needed. If that happens, the runtime PM resume callback
pvr_power_device_resume() is not called, the GPU clocks are not
re-enabled, and the kernel crashes on the next attempt to access GPU
registers as part of the power-on sequence.

Replace calls to pm_runtime_force_suspend() and
pm_runtime_force_resume() with direct calls to the driver's runtime PM
callbacks, pvr_power_device_suspend() and pvr_power_device_resume(),
to ensure clocks are re-enabled and avoid the kernel crash.

Fixes: cc1aeedb98ad ("drm/imagination: Implement firmware infrastructure and META FW support")
Signed-off-by: Alessio Belle <alessio.belle@imgtec.com>
Reviewed-by: Matt Coster <matt.coster@imgtec.com>
Link: https://lore.kernel.org/r/20250624-fix-kernel-crash-gpu-hard-reset-v1-1-6d24810d72a6@imgtec.com
Cc: stable@vger.kernel.org
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
drivers/gpu/drm/imagination/pvr_power.c