]> git.ipfire.org Git - thirdparty/krb5.git/commit
Fix various integer issues
authorGreg Hudson <ghudson@mit.edu>
Mon, 10 Dec 2012 19:18:30 +0000 (14:18 -0500)
committerGreg Hudson <ghudson@mit.edu>
Mon, 10 Dec 2012 19:21:36 +0000 (14:21 -0500)
commitd3c5450ddf0b20855e86dab41735d56c6860156b
tree1013b3c871ce2b5e72c925387115bdbb98853532
parentdb26cd1b6f422c20c062385e0daeb8c95137428d
Fix various integer issues

In kdc_util.c and spnego_mech.c, error returns from ASN.1 length
functions could be ignored because they were assigned to unsigned
values.  In spnego_mech.c, two buffer size checks could be rewritten
to reduce the likelihood of pointer overflow.  In dump.c and
kdc_preauth.c, calloc() could be used to simplify the code and avoid
multiplication overflow.  In pkinit_clnt.c, the wrong value was
checked for a null result from malloc(), and the code could be
simplified.

Reported by Nickolai Zeldovich <nickolai@csail.mit.edu>.

ticket: 7488
src/kadmin/dbutil/dump.c
src/kdc/kdc_preauth.c
src/kdc/kdc_util.c
src/lib/gssapi/spnego/spnego_mech.c
src/plugins/preauth/pkinit/pkinit_clnt.c