]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: sd: Unregister device if device_add_disk() failed in sd_probe()
authorLi Nan <linan122@huawei.com>
Fri, 8 Dec 2023 08:23:35 +0000 (16:23 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:38:13 +0000 (16:38 +0200)
commitd3cd8b9028f4fc7e74b26bf3cb1ea82ae9a00b55
tree4b282f9f597b3ae7f118450e8abed8a771882511
parent6e0745e738ba2cd24a1fa78509b30cd9e92190c0
scsi: sd: Unregister device if device_add_disk() failed in sd_probe()

[ Upstream commit 0296bea01cfa6526be6bd2d16dc83b4e7f1af91f ]

"if device_add() succeeds, you should call device_del() when you want to
get rid of it."

In sd_probe(), device_add_disk() fails when device_add() has already
succeeded, so change put_device() to device_unregister() to ensure device
resources are released.

Fixes: 2a7a891f4c40 ("scsi: sd: Add error handling support for add_disk()")
Signed-off-by: Li Nan <linan122@huawei.com>
Link: https://lore.kernel.org/r/20231208082335.1754205-1-linan666@huaweicloud.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/sd.c