]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: fnic: Replace return codes in fnic_clean_pending_aborts()
authorKaran Tilak Kumar <kartilak@cisco.com>
Thu, 27 Jul 2023 19:39:19 +0000 (12:39 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Aug 2023 16:32:30 +0000 (18:32 +0200)
commitd4326d5256cc0e0c9942220a3a082f7e9f83f892
tree6d8bf41c31f1b933bd3f0d808c049080418e2dc6
parent43c0e16d0c5ec59398b405f4c4aa5a076e656c3f
scsi: fnic: Replace return codes in fnic_clean_pending_aborts()

commit 5a43b07a87835660f91d88a4db11abfea8c523b7 upstream.

fnic_clean_pending_aborts() was returning a non-zero value irrespective of
failure or success.  This caused the caller of this function to assume that
the device reset had failed, even though it would succeed in most cases. As
a consequence, a successful device reset would escalate to host reset.

Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com>
Tested-by: Karan Tilak Kumar <kartilak@cisco.com>
Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
Link: https://lore.kernel.org/r/20230727193919.2519-1-kartilak@cisco.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/fnic/fnic.h
drivers/scsi/fnic/fnic_scsi.c