]> git.ipfire.org Git - thirdparty/libvirt.git/commit
tests: Reduce usage of legacy PCI controllers on PCIe machines
authorAndrea Bolognani <abologna@redhat.com>
Tue, 21 Feb 2017 13:30:39 +0000 (14:30 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Wed, 22 Feb 2017 17:55:55 +0000 (18:55 +0100)
commitd4393c42934dd1960c022f77834f3987eb8de5e7
treebbd50164cb2ec639932c8e658fb2cb88afb2ae99
parent77edbf512701f239b406779811d6fd8bfb9156d9
tests: Reduce usage of legacy PCI controllers on PCIe machines

Up until a while ago, libvirt would automatically add a legacy
PCI controllers combo (dmi-to-pci-bridge + pci-bridge) to any
PCIe machine type (x86_64/q35 and aarch64/virt).

As a result, a number of input and output files in the test
suite ended up containing the legacy PCI controllers, even
though they are not needed or in any way relevant to the
feature being tested.

Get rid of most of the occurrences. Most of the time, this
just means removing the controllers from the input file and
regenerating the output files; in a few instances, some
minor tweaking is performed on the input file, most notably
removing the memory balloon: as memory balloon support was
not the scope of the test being changed, there is no loss
of test coverage from doing so.

Several occurrences of the legacy PCI controllers remain in
the test suite, both because removing their usage would have
required even more tweaking, and because we still want to
have coverage of this perfectly valid combination.
40 files changed:
tests/qemuxml2argvdata/qemuxml2argv-boot-floppy-q35.args
tests/qemuxml2argvdata/qemuxml2argv-boot-floppy-q35.xml
tests/qemuxml2argvdata/qemuxml2argv-bootindex-floppy-q35.args
tests/qemuxml2argvdata/qemuxml2argv-bootindex-floppy-q35.xml
tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-machine.args
tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-machine.xml
tests/qemuxml2argvdata/qemuxml2argv-intel-iommu.args
tests/qemuxml2argvdata/qemuxml2argv-intel-iommu.xml
tests/qemuxml2argvdata/qemuxml2argv-pcie-expander-bus-bad-bus.xml
tests/qemuxml2argvdata/qemuxml2argv-pcie-expander-bus.args
tests/qemuxml2argvdata/qemuxml2argv-pcie-expander-bus.xml
tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port-too-many.xml
tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port.args
tests/qemuxml2argvdata/qemuxml2argv-pcie-root-port.xml
tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-downstream-port.args
tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-downstream-port.xml
tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-upstream-port.args
tests/qemuxml2argvdata/qemuxml2argv-pcie-switch-upstream-port.xml
tests/qemuxml2argvdata/qemuxml2argv-pcihole64-q35.args
tests/qemuxml2argvdata/qemuxml2argv-pcihole64-q35.xml
tests/qemuxml2argvdata/qemuxml2argv-q35-dmi-bad-address1.xml
tests/qemuxml2argvdata/qemuxml2argv-q35-dmi-bad-address2.xml
tests/qemuxml2argvdata/qemuxml2argv-q35-wrong-root.xml
tests/qemuxml2argvdata/qemuxml2argv-q35.args
tests/qemuxml2argvdata/qemuxml2argv-q35.xml
tests/qemuxml2argvdata/qemuxml2argv-usb-controller-default-q35.args
tests/qemuxml2argvdata/qemuxml2argv-usb-controller-default-q35.xml
tests/qemuxml2argvdata/qemuxml2argv-usb-controller-explicit-q35.args
tests/qemuxml2argvdata/qemuxml2argv-usb-controller-explicit-q35.xml
tests/qemuxml2argvdata/qemuxml2argv-vcpu-placement-static.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-intel-iommu.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pcie-expander-bus.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pcie-root-port.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pcie-switch-downstream-port.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pcie-switch-upstream-port.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-pcihole64-q35.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-q35.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-usb-controller-default-q35.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-usb-controller-explicit-q35.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-vcpu-placement-static.xml