]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
staging: gpib: Add missing mutex unlock in ni usb driver
authorDave Penkler <dpenkler@gmail.com>
Sat, 11 Jan 2025 16:15:48 +0000 (17:15 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Jan 2025 05:43:34 +0000 (06:43 +0100)
commitd43f18d94795aa9aacb110a60bc4df76e112f77f
treeb60406a4e4cb6a5a22cbd0df6869f73348256de9
parent55eb3c3a6388420afda1374b353717de32ae9573
staging: gpib: Add missing mutex unlock in ni usb driver

When the buffer allocation for return data in ni_usb_write() fails
we were returning without unlocking the addressed_transfer_lock.

Add the unlock call.

This was detected by smatch:
New smatch warnings:
drivers/staging/gpib/ni_usb/ni_usb_gpib.c:837 ni_usb_write() warn: inconsistent returns '&ni_priv->addressed_transfer_lock'.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202412201550.9NCO57Ye-lkp@intel.com/
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250111161548.27601-1-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/ni_usb/ni_usb_gpib.c