]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: sb: Fix potential double-free of CSP mixer elements
authorTakashi Iwai <tiwai@suse.de>
Tue, 8 Jun 2021 14:04:37 +0000 (16:04 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:02:08 +0000 (16:02 +0200)
commitd4431f45f5607bf7ed3344d0fa441f3383413398
treeec12438038eba8a5d7121e4c069c896e884955fb
parent3a6ebad10d45a8bb76a4bdacc1f8f7514e848c29
ALSA: sb: Fix potential double-free of CSP mixer elements

[ Upstream commit c305366a37441c2ac90b08711cb6f032b43672f2 ]

snd_sb_qsound_destroy() contains the calls of removing the previously
created mixer controls, but it doesn't clear the pointers.  As
snd_sb_qsound_destroy() itself may be repeatedly called via ioctl,
this could lead to double-free potentially.

Fix it by clearing the struct fields properly afterwards.

Link: https://lore.kernel.org/r/20210608140540.17885-4-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/isa/sb/sb16_csp.c