]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Wed, 29 Nov 2017 08:47:33 +0000 (09:47 +0100)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:33:51 +0000 (21:33 -0400)
commitd44d5d39426a1edc1e5045321ccc412f2b949473
tree4301d12de928e4ebf79c8fcf8e4c6dfe81a54337
parentc67f1987fdf46cb4083d55ffa7bf8495a893abdb
RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo()

[ Upstream commit 302d6424e4a293a5761997e6c9fc3dfb1e4c355f ]

With gcc-4.1.2:

    drivers/infiniband/core/iwpm_util.c: In function ‘iwpm_send_mapinfo’:
    drivers/infiniband/core/iwpm_util.c:647: warning: ‘ret’ may be used uninitialized in this function

Indeed, if nl_client is not found in any of the scanned has buckets, ret
will be used uninitialized.

Preinitialize ret to -EINVAL to fix this.

Fixes: 30dc5e63d6a5ad24 ("RDMA/core: Add support for iWARP Port Mapper user space service")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/infiniband/core/iwpm_util.c