]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
eth: fbnic: fix integer overflow warning in TLV_MAX_DATA definition
authorPei Xiao <xiaopei01@kylinos.cn>
Tue, 21 Oct 2025 09:42:27 +0000 (17:42 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 23 Oct 2025 02:21:35 +0000 (19:21 -0700)
commitd550d63d0082268a31e93a10c64cbc2476b98b24
treeb79d977966eeaf4546e1fef4022801b548e98a57
parent114573962a68a527835f2f1433a89bc2f9feac1b
eth: fbnic: fix integer overflow warning in TLV_MAX_DATA definition

The TLV_MAX_DATA macro calculates (PAGE_SIZE - 512) which can exceed
the maximum value of a 16-bit unsigned integer on architectures with
large page sizes, causing compiler warnings:

drivers/net/ethernet/meta/fbnic/fbnic_tlv.h:83:24: warning: conversion
from 'long unsigned int' to 'short unsigned int' changes value from
'261632' to '65024' [-Woverflow]

Fix this by explicitly masking the result to 16 bits using bitwise AND
with 0xFFFF, ensuring the value fits within the expected data type
while maintaining the intended behavior for normal page sizes.

This preserves the existing functionality while eliminating the
compiler warning and potential undefined behavior from integer
truncation.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510190832.3SQkTCHe-lkp@intel.com/
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Link: https://patch.msgid.link/182b9d0235d044d69d7a57c1296cc6f46e395beb.1761039651.git.xiaopei01@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/meta/fbnic/fbnic_tlv.h