]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ionic: use int type for err in ionic_get_module_eeprom_by_page
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Fri, 12 Sep 2025 14:14:24 +0000 (07:14 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sun, 14 Sep 2025 20:19:21 +0000 (13:19 -0700)
commitd586676a2714176bed06cf70467c4e08ac2d4681
tree34e46696d5b503dfff19167037b6b3369a05348f
parentc20302dd42ac2aa3cbb3e8099a8a39b90194d189
ionic: use int type for err in ionic_get_module_eeprom_by_page

The variable 'err' is declared as u32, but it is used to store
negative error codes such as -EINVAL.

Changing the type of 'err' to int ensures proper representation of
negative error codes and aligns with standard kernel error handling
conventions.

Also, there is no need to initialize 'err' since it is always set
before being used.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Shannon Nelson <sln@onemain.com>
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
Link: https://patch.msgid.link/20250912141426.3922545-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/pensando/ionic/ionic_ethtool.c