]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
crypto: ccp - Fix a crash due to incorrect cleanup usage of kfree
authorElla Ma <alansnape3058@gmail.com>
Fri, 9 Jan 2026 15:17:24 +0000 (16:17 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 30 Jan 2026 08:09:32 +0000 (16:09 +0800)
commitd5abcc33ee76bc26d58b39dc1a097e43a99dd438
tree6ccdbd16a34a49b3f7f4565099a1240e90161818
parentda166801d6f5c24376115e7eb1fd33da2eb834de
crypto: ccp - Fix a crash due to incorrect cleanup usage of kfree

Annotating a local pointer variable, which will be assigned with the
kmalloc-family functions, with the `__cleanup(kfree)` attribute will
make the address of the local variable, rather than the address returned
by kmalloc, passed to kfree directly and lead to a crash due to invalid
deallocation of stack address. According to other places in the repo,
the correct usage should be `__free(kfree)`. The code coincidentally
compiled because the parameter type `void *` of kfree is compatible with
the desired type `struct { ... } **`.

Fixes: a71475582ada ("crypto: ccp - reduce stack usage in ccp_run_aes_gcm_cmd")
Signed-off-by: Ella Ma <alansnape3058@gmail.com>
Acked-by: Tom Lendacky <thomas.lendacky@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccp/ccp-ops.c