]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 29 Nov 2017 10:01:09 +0000 (11:01 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Feb 2018 19:07:55 +0000 (11:07 -0800)
commitd5b5f8b30aee9939e837817bb9d0de317160482e
tree856c4c4ca74d3aa349720ee77bafa577c6cd11a8
parentd395c1bb7f92d2bd37a47f28659f49394acf93e6
net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit

[ Upstream commit 15bfe05c8d6386f1a90e9340d15336e85e32aad6 ]

On 64-bit (e.g. powerpc64/allmodconfig):

    drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done':
    drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
dev_kfree_skb_irq((struct sk_buff *)cur_p->app4);
  ^

cdmac_bd.app4 is u32, so it is too small to hold a kernel pointer.

Note that several other fields in struct cdmac_bd are also too small to
hold physical addresses on 64-bit platforms.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/xilinx/Kconfig