]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: usb: lan78xx: Fix lost EEPROM write timeout error(-ETIMEDOUT) in lan78xx_write_r...
authorBhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
Thu, 9 Oct 2025 05:30:09 +0000 (11:00 +0530)
committerDavid S. Miller <davem@davemloft.net>
Sun, 12 Oct 2025 17:13:39 +0000 (18:13 +0100)
commitd5d790ba1558dbb8d179054f514476e2ee970b8e
tree2323db43d84c79ea57f03a5f44dc84b670e7cbbe
parentf3426ac54c42c3260096ddc50b5470eb179fb06a
net: usb: lan78xx: Fix lost EEPROM write timeout error(-ETIMEDOUT) in lan78xx_write_raw_eeprom

The function lan78xx_write_raw_eeprom failed to properly propagate EEPROM
write timeout errors (-ETIMEDOUT). In the timeout  fallthrough path, it first
attempted to restore the pin configuration for LED outputs and then
returned only the status of that restore operation, discarding the
original timeout error saved in ret.

As a result, callers could mistakenly treat EEPROM write operation as
successful even though the EEPROM write had actually timed out with no
or partial data write.

To fix this, handle errors in restoring the LED pin configuration separately.
If the restore succeeds, return any prior EEPROM write timeout error saved
in ret to the caller.

Suggested-by: Oleksij Rempel <o.rempel@pengutronix.de>
Fixes: 8b1b2ca83b20 ("net: usb: lan78xx: Improve error handling in EEPROM and OTP operations")
cc: stable@vger.kernel.org
Signed-off-by: Bhanu Seshu Kumar Valluri <bhanuseshukumar@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/lan78xx.c