]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: meson: t9015: fix function pointer type mismatch
authorJerome Brunet <jbrunet@baylibre.com>
Tue, 13 Feb 2024 21:58:04 +0000 (22:58 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:48 +0000 (18:19 -0400)
commitd6585d694fb4cfa0ff6f3d52e5f8e03e8514c10b
treea8074842ed0714bfe22bff15d8f8dcd0f2a6bd14
parentb188c9e1d5d26ce1ca7223a2677f48f387543a22
ASoC: meson: t9015: fix function pointer type mismatch

[ Upstream commit 5ad992c71b6a8e8a547954addc7af9fbde6ca10a ]

clang-16 warns about casting functions to incompatible types, as is done
here to call clk_disable_unprepare:

sound/soc/meson/t9015.c:274:4: error: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
  274 |                         (void(*)(void *))clk_disable_unprepare,

The pattern of getting, enabling and setting a disable callback for a
clock can be replaced with devm_clk_get_enabled(), which also fixes
this warning.

Fixes: 33901f5b9b16 ("ASoC: meson: add t9015 internal DAC driver")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Justin Stitt <justinstitt@google.com>
Link: https://msgid.link/r/20240213215807.3326688-3-jbrunet@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/meson/t9015.c