]> git.ipfire.org Git - thirdparty/squid.git/commit
Bug 4912: same-name notes being appended instead of replaced (#393)
authorAmish <3330468+amishmm@users.noreply.github.com>
Wed, 22 May 2019 05:42:06 +0000 (05:42 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Wed, 22 May 2019 06:05:15 +0000 (06:05 +0000)
commitd665de37c2e6032068360b83b7ae372a77f5d0f4
tree82ab374ea960b9318a0a72eb78219dea0fde2789
parent4cb75d28bddf1e064002b3631fd424ba616f5f1b
Bug 4912: same-name notes being appended instead of replaced (#393)

When auth helper replies with clt_conn_tag=foo (or any KV pair) and
then later in future replaces it with clt_conn_tag=bar. The new pair
was getting appended instead of getting replaced.

i.e. notes would contain two KV pairs:
clt_conn_tag=foo
clt_conn_tag=bar

This fixes it and also fixes:
https://bugs.squid-cache.org/show_bug.cgi?id=4912
src/Notes.cc
src/Notes.h
src/auth/basic/UserRequest.cc
src/auth/digest/UserRequest.cc
src/auth/negotiate/UserRequest.cc
src/auth/ntlm/UserRequest.cc