]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usbnet: ipheth: fix possible overflow in DPE length check
authorFoster Snowhill <forst@pen.gy>
Sat, 25 Jan 2025 23:54:03 +0000 (00:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Feb 2025 09:05:15 +0000 (10:05 +0100)
commitd677e7dd59ad6837496f5a02d8e5d39824278dfd
treebc3f6f6f048cb53db304154af0d262c08c30b5b4
parentdf5bc4891b3dbc32a77f7205dff731c1494b31d5
usbnet: ipheth: fix possible overflow in DPE length check

commit c219427ed296f94bb4b91d08626776dc7719ee27 upstream.

Originally, it was possible for the DPE length check to overflow if
wDatagramIndex + wDatagramLength > U16_MAX. This could lead to an OoB
read.

Move the wDatagramIndex term to the other side of the inequality.

An existing condition ensures that wDatagramIndex < urb->actual_length.

Fixes: a2d274c62e44 ("usbnet: ipheth: add CDC NCM support")
Cc: stable@vger.kernel.org
Signed-off-by: Foster Snowhill <forst@pen.gy>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/usb/ipheth.c