]> git.ipfire.org Git - thirdparty/iptables.git/commit
arptables-nft: fix decoding of hlen on bigendian platforms
authorFlorian Westphal <fw@strlen.de>
Fri, 22 Feb 2019 12:26:05 +0000 (13:26 +0100)
committerFlorian Westphal <fw@strlen.de>
Fri, 22 Feb 2019 15:50:14 +0000 (16:50 +0100)
commitd68672a641439b72bccfcb39d50f26fe3f915c19
tree128af8af28fd18116bd6283483e85352339b609f
parent73a0c2ef36d15e8277f0e00337736668b325381a
arptables-nft: fix decoding of hlen on bigendian platforms

The existing test fail with:
extensions/libarpt_standard.t: ERROR: line 2 (cannot find: arptables -I INPUT -s 192.168.0.1)

... because hlen is 0 instead of expected "6".
The rule is correct, i.e. this is a decode/display bug: arp_hlen is
specified as 'unsigned short' instead of uint8_t.

On LSB systems, this doesn't matter but on MSB the value then is '0x600'
instead of '0x006' which becomes 0 when assignment to the u8 header field.

Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Phil Sutter <phil@nwl.cc>
iptables/nft-arp.c