]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs_repair: properly detect reserved attribute names
authorEric Sandeen <sandeen@redhat.com>
Tue, 26 May 2015 22:43:02 +0000 (08:43 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 26 May 2015 22:43:02 +0000 (08:43 +1000)
commitd6cfd5aee844e7e11f4e313da370bbc4a4cec450
tree33dec55e654cb6edfaaf6a83da20f660c66e7703
parentc8c08373e9e97de2d463fc6ba65ff89a5a2bb208
xfs_repair: properly detect reserved attribute names

This function in xfs_repair tries to make sure that if an attr
name reserved for acls exists in the root namespace, then its
value is a valid acl.

However, because it only compares up to the length of the
reserved name, superstrings may match and cause false positive
xfs_repair errors.

Ensure that both the length and the content match before
flagging it as an error.

Spotted-by: Zach Brown <zab@zabbo.net>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
repair/attr_repair.c