]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: forbid creating subvol qgroups
authorBoris Burkov <boris@bur.io>
Thu, 11 Jan 2024 01:51:26 +0000 (17:51 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Feb 2024 07:42:22 +0000 (08:42 +0100)
commitd7247ce32ab2a2d4a3647a9679dda628407461b9
tree69281af8d62e8dcabc999239ccb4f05203e1b9f9
parent4cee42fcf54fec46b344681e7cc4f234bb22f85a
btrfs: forbid creating subvol qgroups

commit 0c309d66dacddf8ce939b891d9ead4a8e21ad6f0 upstream.

Creating a qgroup 0/subvolid leads to various races and it isn't
helpful, because you can't specify a subvol id when creating a subvol,
so you can't be sure it will be the right one. Any requirements on the
automatic subvol can be gratified by using a higher level qgroup and the
inheritance parameters of subvol creation.

Fixes: cecbb533b5fc ("btrfs: record simple quota deltas in delayed refs")
CC: stable@vger.kernel.org # 4.14+
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Boris Burkov <boris@bur.io>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/ioctl.c