]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
can: m_can: m_can_close(): stop clocks after device has been shut down
authorMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 9 Sep 2024 13:07:41 +0000 (15:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:28:58 +0000 (16:28 +0200)
commitd7572187bce65ec13e98e5da101a651d4cbdc2a5
tree18c8d84f439dd1958f2ea71b6eec323ccc422f0f
parent7fb4f5605c3e77fa36513e0572d4f4690f562d4a
can: m_can: m_can_close(): stop clocks after device has been shut down

[ Upstream commit 2c09b50efcad985cf920ca88baa9aa52b1999dcc ]

After calling m_can_stop() an interrupt may be pending or NAPI might
still be executed. This means the driver might still touch registers
of the IP core after the clocks have been disabled. This is not good
practice and might lead to aborts depending on the SoC integration.

To avoid these potential problems, make m_can_close() symmetric to
m_can_open(), i.e. stop the clocks at the end, right before shutting
down the transceiver.

Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support")
Link: https://patch.msgid.link/20240910-can-m_can-fix-ifup-v3-2-6c1720ba45ce@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/can/m_can/m_can.c