]> git.ipfire.org Git - thirdparty/linux.git/commit
ethtool: mark ETHER_FLOW as usable for Rx hash
authorJakub Kicinski <kuba@kernel.org>
Tue, 8 Jul 2025 22:06:38 +0000 (15:06 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 11 Jul 2025 00:57:49 +0000 (17:57 -0700)
commitd7974697de4d6fa1a1ed9ca43616a8500046f25a
treee15322f569fc439a862a9976578d56f2292ce006
parentf7c595c9d9f4cce9ec335f0d3c5d875bb547f9d5
ethtool: mark ETHER_FLOW as usable for Rx hash

Looks like some drivers (ena, enetc, fbnic.. there's probably more)
consider ETHER_FLOW to be legitimate target for flow hashing.
I'm not sure how intentional that is from the uAPI perspective
vs just an effect of ethtool IOCTL doing minimal input validation.
But Netlink will do strict validation, so we need to decide whether
we allow this use case or not. I don't see a strong reason against
it, and rejecting it would potentially regress a number of drivers.
So update the comments and flow_type_hashable().

Link: https://patch.msgid.link/20250708220640.2738464-4-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/uapi/linux/ethtool.h
net/ethtool/ioctl.c