]> git.ipfire.org Git - thirdparty/coreutils.git/commit
Fix to avoid a denial-of-service attack if the display width is
authorJim Meyering <jim@meyering.net>
Tue, 14 Oct 2003 09:09:43 +0000 (09:09 +0000)
committerJim Meyering <jim@meyering.net>
Tue, 14 Oct 2003 09:09:43 +0000 (09:09 +0000)
commitd7bed21394dc27fa3ff40af2fe5963baf73e1311
treee9216bc0104c2f0097889c0233b951ac9b1229eb
parent49c9c00c8a7dbc571e2ea50ca47f29535699bb8d
Fix to avoid a denial-of-service attack if the display width is
enormous.  Also, clean up the code a bit by removing duplicate code.

(init_column_info): Remove forward decl; no longer needed.
(calculate_columns): New function, that contains code that used
to be common to print_many_per_line and print_horizontal.
(print_many_per_line, print_horizontal): Use it.
(decode_switches): Set max_idx here, not in calculate_columns.
(print_current_files): Don't call init_column_info; calculate_columns
now does that.
(init_column_info): Don't allocate a lot more space than is needed
to represent the current set of files.  Allocate all the new
size_t cells in one call to xnmalloc, rather than a row at a time.
src/ls.c