]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: quic: ensure handshake speed up is only run once per conn
authorAmaury Denoyelle <adenoyelle@haproxy.com>
Wed, 11 Feb 2026 10:34:15 +0000 (11:34 +0100)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Thu, 12 Feb 2026 08:09:44 +0000 (09:09 +0100)
commitd80f0143c9b6a0b83b05abf79449240591dccd2e
tree9131ec7ac431c2058431bba9684735f6878543a2
parentb65df062be427710769e989bfd142a8625aa5219
BUG/MINOR: quic: ensure handshake speed up is only run once per conn

When a duplicated CRYPTO frame is received during handshake, a server
may consider that there was a packet loss and immediately retransmit its
pending CRYPTO data without having to wait for PTO expiration. However,
RFC 9002 indicates that this should only be performed at most once per
connection to avoid excessive packet transmission.

QUIC connection is flagged with QUIC_FL_CONN_HANDSHAKE_SPEED_UP to mark
that a fast retransmit has been performed. However, during the
refactoring on CRYPTO handling with the storage conversion from ncbuf to
ncbmbuf, the check on the flag was accidentely removed. The faulty patch
is the following one :

  commit f50425c021eceb324add6873b58cc5f366554d31
  MINOR: quic: remove received CRYPTO temporary tree storage

This patch adds again the check on QUIC_FL_CONN_HANDSHAKE_SPEED_UP
before initiating fast retransmit. This ensures this is only performed
once per connection.

This must be backported up to 3.3.
src/quic_rx.c