]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ks8851-ml: Fix 16-bit IO operation
authorMarek Vasut <marex@denx.de>
Sat, 15 Feb 2020 16:54:19 +0000 (17:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Mar 2020 06:18:26 +0000 (07:18 +0100)
commitd8437c3883c02e6f1575e680ceeab9f31fe1eceb
tree0ae9c7b5dcd5f82c8410bf6a4f9e1933946f9aa4
parent085793efc6efd454172e4be36f1c222ef2d44075
net: ks8851-ml: Fix 16-bit IO operation

[ Upstream commit 58292104832fef6cb4a89f736012c0e0724c3442 ]

The Micrel KSZ8851-16MLLI datasheet DS00002357B page 12 states that
BE[3:0] signals are active high. This contradicts the measurements
of the behavior of the actual chip, where these signals behave as
active low. For example, to read the CIDER register, the bus must
expose 0xc0c0 during the address phase, which means BE[3:0]=4'b1100.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: David S. Miller <davem@davemloft.net>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Petr Stetiar <ynezz@true.cz>
Cc: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/micrel/ks8851_mll.c