]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Bluetooth: btrtl: Prevent potential NULL dereference
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 2 Apr 2025 11:01:41 +0000 (14:01 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 08:43:49 +0000 (10:43 +0200)
commitd8441818690d795232331bd8358545c5c95b6b72
treed7452bab58e06aafa0fd661281978a8b12876eb5
parentd54bc626c81364bcd8355f5d3fcec06e3a416cbe
Bluetooth: btrtl: Prevent potential NULL dereference

[ Upstream commit 324dddea321078a6eeb535c2bff5257be74c9799 ]

The btrtl_initialize() function checks that rtl_load_file() either
had an error or it loaded a zero length file.  However, if it loaded
a zero length file then the error code is not set correctly.  It
results in an error pointer vs NULL bug, followed by a NULL pointer
dereference.  This was detected by Smatch:

drivers/bluetooth/btrtl.c:592 btrtl_initialize() warn: passing zero to 'ERR_PTR'

Fixes: 26503ad25de8 ("Bluetooth: btrtl: split the device initialization into smaller parts")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/bluetooth/btrtl.c