]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nvme: always punt polled uring_cmd end_io work to task_work
authorJens Axboe <axboe@kernel.dk>
Fri, 13 Jun 2025 19:37:41 +0000 (13:37 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 6 Jul 2025 08:58:04 +0000 (10:58 +0200)
commitd85473b0e9cc2d9c31bc9739675460dfd8f0936a
tree64c84691b302f8b9212ba4fcc43e3415c94f13ae
parentb80d171c2ff6be947472d977521cc056ca42b027
nvme: always punt polled uring_cmd end_io work to task_work

Commit 9ce6c9875f3e995be5fd720b65835291f8a609b1 upstream.

Currently NVMe uring_cmd completions will complete locally, if they are
polled. This is done because those completions are always invoked from
task context. And while that is true, there's no guarantee that it's
invoked under the right ring context, or even task. If someone does
NVMe passthrough via multiple threads and with a limited number of
poll queues, then ringA may find completions from ringB. For that case,
completing the request may not be sound.

Always just punt the passthrough completions via task_work, which will
redirect the completion, if needed.

Cc: stable@vger.kernel.org
Fixes: 585079b6e425 ("nvme: wire up async polling for io passthrough commands")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nvme/host/ioctl.c