]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ima: Fix return value of ima_write_policy()
authorRoberto Sassu <roberto.sassu@huawei.com>
Mon, 27 Apr 2020 10:31:28 +0000 (12:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 May 2020 14:41:40 +0000 (16:41 +0200)
commitd8d4da8a96b0763eca94656940c0ccdff1a1f39f
treef532d2bf6065ed7129d333a6afacae429e7809cd
parentab97e5a9fdda460e4ef43cae75139193a46b12eb
ima: Fix return value of ima_write_policy()

[ Upstream commit 2e3a34e9f409ebe83d1af7cd2f49fca7af97dfac ]

This patch fixes the return value of ima_write_policy() when a new policy
is directly passed to IMA and the current policy requires appraisal of the
file containing the policy. Currently, if appraisal is not in ENFORCE mode,
ima_write_policy() returns 0 and leads user space applications to an
endless loop. Fix this issue by denying the operation regardless of the
appraisal mode.

Cc: stable@vger.kernel.org # 4.10.x
Fixes: 19f8a84713edc ("ima: measure and appraise the IMA policy itself")
Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Reviewed-by: Krzysztof Struczynski <krzysztof.struczynski@huawei.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
security/integrity/ima/ima_fs.c