]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: gadget: f_midi: fix MIDI Streaming descriptor lengths
authorJohn Keeping <jkeeping@inmusicbrands.com>
Thu, 30 Jan 2025 19:50:34 +0000 (19:50 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:50:38 +0000 (12:50 +0100)
commitd8e86700c8a8cf415e300a0921acd6a8f9b494f8
tree76d42249e742f5c453eb52f04ba4352581a3b8a7
parentaeda961736f3e96bcdbbf5d026ef1be6ba261a83
usb: gadget: f_midi: fix MIDI Streaming descriptor lengths

commit da1668997052ed1cb00322e1f3b63702615c9429 upstream.

While the MIDI jacks are configured correctly, and the MIDIStreaming
endpoint descriptors are filled with the correct information,
bNumEmbMIDIJack and bLength are set incorrectly in these descriptors.

This does not matter when the numbers of in and out ports are equal, but
when they differ the host will receive broken descriptors with
uninitialized stack memory leaking into the descriptor for whichever
value is smaller.

The precise meaning of "in" and "out" in the port counts is not clearly
defined and can be confusing.  But elsewhere the driver consistently
uses this to match the USB meaning of IN and OUT viewed from the host,
so that "in" ports send data to the host and "out" ports receive data
from it.

Cc: stable <stable@kernel.org>
Fixes: c8933c3f79568 ("USB: gadget: f_midi: allow a dynamic number of input and output ports")
Signed-off-by: John Keeping <jkeeping@inmusicbrands.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20250130195035.3883857-1-jkeeping@inmusicbrands.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/f_midi.c