]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI/MSI: Destroy sysfs before freeing entries
authorThomas Gleixner <tglx@linutronix.de>
Tue, 9 Nov 2021 13:53:57 +0000 (14:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 10:36:18 +0000 (11:36 +0100)
commitd8ea896354e3177316a24e2fd379785082d1a2fb
tree3e4573d8af4f9c7099d992a55d1a9b925283cd02
parentbb07fc138e61cef1640fdd136272febc7453b428
PCI/MSI: Destroy sysfs before freeing entries

commit 3735459037114d31e5acd9894fad9aed104231a0 upstream.

free_msi_irqs() frees the MSI entries before destroying the sysfs entries
which are exposing them. Nothing prevents a concurrent free while a sysfs
file is read and accesses the possibly freed entry.

Move the sysfs release ahead of freeing the entries.

Fixes: 1c51b50c2995 ("PCI/MSI: Export MSI mode using attributes, not kobjects")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/87sfw5305m.ffs@tglx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pci/msi.c