]> git.ipfire.org Git - thirdparty/openssl.git/commit
Fix off-by-one in "groups list" parser
authorViktor Dukhovni <viktor@openssl.org>
Wed, 15 Apr 2026 09:14:48 +0000 (19:14 +1000)
committerTomas Mraz <tomas@openssl.foundation>
Thu, 16 Apr 2026 17:17:30 +0000 (19:17 +0200)
commitd8f1579884cc6c2ea40c8e2aca93f20d24e4962a
treea54432d998f5cd78b5a81d351118d8c50796027b
parent350adfe3f922062986195e9bc2ec1ed5dd5efc37
Fix off-by-one in "groups list" parser

When parsing the configured TLS supported groups list reallocating of the list
of "tuples" happened one element too late.  The current tuple count is the
number of "closed" (completed) tuples, the currently active tuple occupies
one more slot, so we need space for `tuple count + 1` elements.

This is only an issue while parsing configurations (not attacker controlled),
and only if the group list somehow manages to contain 32 or distinct elements
(each in its own tuple, and even though OpenSSL does not implement that many
groups in typical builds).

Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.foundation>
MergeDate: Thu Apr 16 17:17:38 2026
(Merged from https://github.com/openssl/openssl/pull/30838)
ssl/t1_lib.c