]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
perf/x86/intel/pt: Fix sampling synchronization
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 15 Jul 2024 16:07:00 +0000 (19:07 +0300)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 29 Jul 2024 10:16:24 +0000 (12:16 +0200)
commitd92792a4b26e50b96ab734cbe203d8a4c932a7a9
tree57a7a5891b46a2db0e4dc4a08f94115528114096
parentb1d0e15c8725d21a73c22c099418a63940261041
perf/x86/intel/pt: Fix sampling synchronization

pt_event_snapshot_aux() uses pt->handle_nmi to determine if tracing
needs to be stopped, however tracing can still be going because
pt->handle_nmi is set to zero before tracing is stopped in pt_event_stop,
whereas pt_event_snapshot_aux() requires that tracing must be stopped in
order to copy a sample of trace from the buffer.

Instead call pt_config_stop() always, which anyway checks config for
RTIT_CTL_TRACEEN and does nothing if it is already clear.

Note pt_event_snapshot_aux() can continue to use pt->handle_nmi to
determine if the trace needs to be restarted afterwards.

Fixes: 25e8920b301c ("perf/x86/intel/pt: Add sampling support")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20240715160712.127117-2-adrian.hunter@intel.com
arch/x86/events/intel/pt.c