]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
hwmon: replace snprintf in show functions with sysfs_emit
authorGuenter Roeck <linux@roeck-us.net>
Wed, 31 Dec 2025 20:41:35 +0000 (15:41 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jan 2026 12:12:03 +0000 (13:12 +0100)
commitd92baf7703aef225a05bed7d33a4fd07cdf6577a
treed0442b13bc336c87c7e1c7365da05d5644afd5b5
parenta8f1e445ce3545c90d69c9e8ff8f7821825fe810
hwmon: replace snprintf in show functions with sysfs_emit

[ Upstream commit 1f4d4af4d7a1c794a4f003f75fcfd38fafb5dff3 ]

coccicheck complains about the use of snprintf() in sysfs
show functions.

drivers/hwmon/ina3221.c:701:8-16: WARNING: use scnprintf or sprintf

This results in a large number of patch submissions. Fix it all in
one go using the following coccinelle rules. Use sysfs_emit instead
of scnprintf or sprintf since that makes more sense.

@depends on patch@
identifier show, dev, attr, buf;
@@

ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
{
<...
  return
- snprintf(buf, \( PAGE_SIZE \| PAGE_SIZE - 1 \),
+ sysfs_emit(buf,
...);
...>
}

@depends on patch@
identifier show, dev, attr, buf, rc;
@@

ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
{
<...
  rc =
- snprintf(buf, \( PAGE_SIZE \| PAGE_SIZE - 1 \),
+ sysfs_emit(buf,
...);
...>
}

While at it, remove unnecessary braces and as well as unnecessary
else after return statements to address checkpatch warnings in the
resulting patch.

Cc: Zihao Tang <tangzihao1@hisilicon.com>
Cc: Jay Fang <f.fangjian@huawei.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Stable-dep-of: b8d5acdcf525 ("hwmon: (max16065) Use local variable to avoid TOCTOU")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
24 files changed:
drivers/hwmon/applesmc.c
drivers/hwmon/ina209.c
drivers/hwmon/ina2xx.c
drivers/hwmon/ina3221.c
drivers/hwmon/lineage-pem.c
drivers/hwmon/ltc2945.c
drivers/hwmon/ltc2990.c
drivers/hwmon/ltc4151.c
drivers/hwmon/ltc4215.c
drivers/hwmon/ltc4222.c
drivers/hwmon/ltc4260.c
drivers/hwmon/ltc4261.c
drivers/hwmon/max16065.c
drivers/hwmon/occ/common.c
drivers/hwmon/occ/sysfs.c
drivers/hwmon/pmbus/inspur-ipsps.c
drivers/hwmon/pmbus/pmbus_core.c
drivers/hwmon/s3c-hwmon.c
drivers/hwmon/sch5627.c
drivers/hwmon/sch5636.c
drivers/hwmon/smm665.c
drivers/hwmon/stts751.c
drivers/hwmon/vexpress-hwmon.c
drivers/hwmon/xgene-hwmon.c